Changeset 5f82b6c for remit/vouchers/views.py

Timestamp:

Jul 6, 2014, 4:38:22 AM (11 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master

Children:

7a292ed

Parents:

bc1da44

git-author:

Alex Dehnert <adehnert@…> (07/06/14 04:38:22)

git-committer:

Alex Dehnert <adehnert@…> (07/06/14 04:38:22)

Message:

Replace ListViewWithContext? with simpler render_to_response

It turns out that if you're specifying a queryset and a bunch of extra context,
ListView? isn't *actually* buying much...

File:

• remit/vouchers/views.py (modified) (2 diffs)

remit/vouchers/views.py

@@ -2 +2 @@
 from vouchers.models import ReimbursementRequest, Documentation
 from finance_core.models import BudgetTerm, BudgetArea
-from util.shortcuts import get_403_response, ListViewWithContext
+from util.shortcuts import get_403_response
 
 from django.contrib.auth.decorators import user_passes_test, login_required
@@ -427 +427 @@
 
     # GENERATE THE REQUEST
-    callable = ListViewWithContext.as_view(
-        queryset=qs,
-        extra_context={
-            'actions' : actions,
-            'selected_ids'  : list_to_keys(selected_rr_ids),
-            'action_message': apply_action_message,
-            'action_errors' : apply_action_errors,
-            'useronly': useronly,
-            'order'   : order,
-            'orders'  : request_list_orders,
-            'approval_status' : approval_status,
-            'approval_states':  vouchers.models.APPROVAL_STATES,
-            'pagename': 'list_requests',
-        },
-    )
-    return callable(http_request)
+
+    context = {
+        'object_list' : qs,
+        'actions' : actions,
+        'selected_ids'  : list_to_keys(selected_rr_ids),
+        'action_message': apply_action_message,
+        'action_errors' : apply_action_errors,
+        'useronly': useronly,
+        'order'   : order,
+        'orders'  : request_list_orders,
+        'approval_status' : approval_status,
+        'approval_states':  vouchers.models.APPROVAL_STATES,
+        'pagename': 'list_requests',
+    }
+    return render_to_response('vouchers/reimbursementrequest_list.html', context, context_instance=RequestContext(http_request), )