Changeset c9047b1 for remit/mit

Timestamp:

May 24, 2011, 4:31:12 PM (14 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, client

Children:

3b03cc6

Parents:

a5ef930

git-author:

Alex Dehnert <adehnert@…> (05/24/11 16:16:21)

git-committer:

Alex Dehnert <adehnert@…> (05/24/11 16:31:12)

Message:

Properly escape the zwrite command line

Thanks to Anders for bringing this issue to my attention.

File:

• remit/mit/__init__.py (modified) (2 diffs)

remit/mit/__init__.py

@@ +1 @@
+import subprocess
+
 from django.contrib.auth.middleware import RemoteUserMiddleware
 from django.contrib.auth.backends import RemoteUserBackend
@@ -5 +7 @@
 
 def zephyr(msg, clas='remit', instance='log', rcpt='adehnert',):
-    import os
-    os.system("zwrite -d -c '%s' -i '%s' '%s' -m '%s'" % (clas, instance, rcpt, msg, ))
+    proc = subprocess.Popen(
+        ['zwrite', '-d', '-n', '-c', clas, '-i', instance, rcpt, ],
+        stdin=subprocess.PIPE, stdout=subprocess.PIPE
+    )
+    proc.communicate(msg)
 
 class ScriptsRemoteUserMiddleware(RemoteUserMiddleware):