Changeset 80d8926


Ignore:
Timestamp:
Jul 7, 2014, 10:06:58 PM (11 years ago)
Author:
Alex Dehnert <adehnert@…>
Branches:
master
Children:
56c7337
Parents:
b61cf1a
git-author:
Alex Dehnert <adehnert@…> (07/07/14 22:06:58)
git-committer:
Alex Dehnert <adehnert@…> (07/07/14 22:06:58)
Message:

Refactor email-sending part of RR approval

File:
1 edited

Legend:

Unmodified
Added
Removed
  • remit/vouchers/models.py

    rb61cf1a r80d8926  
    118118        self.save()
    119119
     120    def send_approval_email(self, approver, approval_type):
     121        tmpl = get_template('vouchers/emails/request_approval_admin.txt')
     122        ctx = Context({
     123            'approver': approver,
     124            'request': self,
     125            'approval_type': approval_type,
     126        })
     127        body = tmpl.render(ctx)
     128        mail_admins(
     129            'Request approval: %s approved $%s [%s]' % (
     130                approver,
     131                self.amount,
     132                approval_type,
     133            ),
     134            body,
     135        )
     136
    120137    def approve(self, approver, signatory_name, signatory_email=None, ):
    121138        """Mark a request as approved.
     
    126143        """
    127144        self.convert_to_voucher(signatory_name, signatory_email,)
    128         tmpl = get_template('vouchers/emails/request_approval_admin.txt')
    129         ctx = Context({
    130             'approver': approver,
    131             'request': self,
    132             'approval_type': 'voucher',
    133         })
    134         body = tmpl.render(ctx)
    135         mail_admins(
    136             'Request approval: %s approved $%s [voucher]' % (
    137                 approver,
    138                 self.amount,
    139             ),
    140             body,
    141         )
     145        self.send_approval_email(approver, 'voucher')
    142146
    143147    def approve_as_rfp(self, approver, ):
    144148        self.convert_to_rfp()
    145         tmpl = get_template('vouchers/emails/request_approval_admin.txt')
    146         ctx = Context({
    147             'approver': approver,
    148             'request': self,
    149             'approval_type': 'RFP',
    150         })
    151         body = tmpl.render(ctx)
    152         mail_admins(
    153             'Request approval: %s approved $%s [RFP]' % (
    154                 approver,
    155                 self.amount,
    156             ),
    157             body,
    158         )
    159 
     149        self.send_approval_email(approver, 'RFP')
    160150
    161151    def review_link(self, ):
Note: See TracChangeset for help on using the changeset viewer.